[Marble-devel] Review Request: Interface for Small Screen Devices

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5011/#review7097
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.h
<http://reviewboard.kde.org/r/5011/#comment7235>

    Can we move these private slots over into the private class ? You can use Q_PRIVATE_SLOT in order to achieve this.



/trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.cpp
<http://reviewboard.kde.org/r/5011/#comment7236>

    Well, we did this wrong already before you added your connects. Still: We should disconnect all connects that get established here. Otherwise calling setMarbleWidget multiple times will create multiple connects.



/trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.h
<http://reviewboard.kde.org/r/5011/#comment7237>

    Cool that we are using this. But where do we use this? A comment wouldn't hurt



/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.h
<http://reviewboard.kde.org/r/5011/#comment7238>

    const QString&



/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.h
<http://reviewboard.kde.org/r/5011/#comment7239>

    I guess in Qt this usually would be "setRecenteringEnabled( bool )"



/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.cpp
<http://reviewboard.kde.org/r/5011/#comment7240>

    disconnect before connect for all these connects?


- Torsten


On 2010-08-15 19:05:04, Siddharth Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5011/
> -----------------------------------------------------------
> 
> (Updated 2010-08-15 19:05:04)
> 
> 
> Review request for marble and Dennis Nienhüser.
> 
> 
> Summary
> -------
> 
> An interface of Routing Plugin for Small Screen Devices is added. The Routing Plugin for Small Screen Device contains options for navigation( recenter, auto zoom), routing information widget, zoom in and zoom out functionalities.
> The routing information widget for desktop version of marble, now shows the next instruction as well as the distance remaining to reach it.
> 
> The instruction point now grows in two levels when the gps location gets closer to it instead of displaying the instruction text at it. 1) The instruction point going to be visited grows in size 2) When the gps device is at certain time away from the instruction point, it grows a bit further.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.h 1164052 
>   /trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.cpp 1164052 
>   /trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.ui 1164052 
>   /trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.h 1164052 
>   /trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp 1164052 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp 1164052 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1164052 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1164052 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h 1164052 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp 1164052 
>   /trunk/KDE/kdeedu/marble/src/lib/graphicsview/ScreenGraphicsItem_p.h 1164052 
>   /trunk/KDE/kdeedu/marble/src/lib/graphicsview/WidgetGraphicsItem.h 1164052 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/AdjustNavigation.h 1164052 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/AdjustNavigation.cpp 1164052 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingLayer.cpp 1164052 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.h 1164052 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.cpp 1164052 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.h 1164052 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.cpp 1164052 
>   /trunk/KDE/kdeedu/marble/src/marble.qrc 1164052 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/navigation/NavigationFloatItem.h 1164052 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/navigation/NavigationFloatItem.cpp 1164052 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/progress/ProgressFloatItem.h 1164052 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/CMakeLists.txt 1164052 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingInformationWidget.ui PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingInformationWidgetSmall.ui PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingItemWidget.ui 1164052 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.h 1164052 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.cpp 1164052 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingWidgetSmall.ui PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/5011/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Routing Information Widget for Desktop version of marble
>   http://reviewboard.kde.org/r/5011/s/478/
> Routing Widget for small screen devices. This screen shot shows the routing information widget which appears on clicking "R" on the routing widget
>   http://reviewboard.kde.org/r/5011/s/479/
> navigation menu for routing widget for small screen devices
>   http://reviewboard.kde.org/r/5011/s/480/
> [New]RoutingInformation for Desktop Marble
>   http://reviewboard.kde.org/r/5011/s/483/
> [new] Routing information for Small Screen Devices
>   http://reviewboard.kde.org/r/5011/s/484/
> 
> 
> Thanks,
> 
> Siddharth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100816/0ca98c90/attachment.htm