<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5011/">http://reviewboard.kde.org/r/5011/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5011/diff/2/?file=34013#file34013line52" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class MARBLE_EXPORT CurrentLocationWidget : public QWidget</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">52</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">private</span> <span class="n">Q_SLOTS</span><span class="o">:</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">52</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">private</span> <span class="n">Q_SLOTS</span><span class="o">:</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can we move these private slots over into the private class ? You can use Q_PRIVATE_SLOT in order to achieve this.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5011/diff/2/?file=34014#file34014line94" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void CurrentLocationWidget::setMarbleWidget( MarbleWidget *widget )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">92</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="n">d</span><span class="o">-></span><span class="n">m_currentLocationUi</span><span class="p">.</span><span class="n">locationLabel</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span> <span class="n">linkActivated</span><span class="p">(</span> <span class="n">QString</span> <span class="p">)</span> <span class="p">),</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">94</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="n">d</span><span class="o">-></span><span class="n">m_currentLocationUi</span><span class="p">.</span><span class="n">locationLabel</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span> <span class="n">linkActivated</span><span class="p">(</span> <span class="n">QString</span> <span class="p">)</span> <span class="p">),</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, we did this wrong already before you added your connects. Still: We should disconnect all connects that get established here. Otherwise calling setMarbleWidget multiple times will create multiple connects.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5011/diff/2/?file=34016#file34016line17" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">17</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#define QT_USE_FAST_CONCATENATION</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Cool that we are using this. But where do we use this? A comment wouldn't hurt</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5011/diff/2/?file=34040#file34040line112" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">109</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">selectTheme</span><span class="p">(</span> <span class="n">QString</span> <span class="n">theme</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">const QString&</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5011/diff/2/?file=34040#file34040line150" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">147</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">disableRecentering</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess in Qt this usually would be "setRecenteringEnabled( bool )"</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5011/diff/2/?file=34041#file34041line185" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString RoutingPlugin::nameId() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">174</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span> <span class="n">m_marbleWidget</span><span class="o">-></span><span class="n">model</span><span class="p">()</span><span class="o">-></span><span class="n">positionTracking</span><span class="p">(),</span> <span class="n">SIGNAL</span><span class="p">(</span> <span class="n">positionProviderPluginChanged</span><span class="p">(</span> <span class="n">PositionProviderPlugin</span><span class="o">*</span> <span class="p">)</span> <span class="p">),</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">disconnect before connect for all these connects?</pre>
</div>
<br />
<p>- Torsten</p>
<br />
<p>On August 15th, 2010, 7:05 p.m., Siddharth Srivastava wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble and Dennis Nienhüser.</div>
<div>By Siddharth Srivastava.</div>
<p style="color: grey;"><i>Updated 2010-08-15 19:05:04</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">An interface of Routing Plugin for Small Screen Devices is added. The Routing Plugin for Small Screen Device contains options for navigation( recenter, auto zoom), routing information widget, zoom in and zoom out functionalities.
The routing information widget for desktop version of marble, now shows the next instruction as well as the distance remaining to reach it.
The instruction point now grows in two levels when the gps location gets closer to it instead of displaying the instruction text at it. 1) The instruction point going to be visited grows in size 2) When the gps device is at certain time away from the instruction point, it grows a bit further.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.ui <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/graphicsview/ScreenGraphicsItem_p.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/graphicsview/WidgetGraphicsItem.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/AdjustNavigation.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/AdjustNavigation.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingLayer.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/marble.qrc <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/navigation/NavigationFloatItem.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/navigation/NavigationFloatItem.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/progress/ProgressFloatItem.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/CMakeLists.txt <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingInformationWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingInformationWidgetSmall.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingItemWidget.ui <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.h <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.cpp <span style="color: grey">(1164052)</span></li>
<li>/trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingWidgetSmall.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5011/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://reviewboard.kde.org/r/5011/s/478/"><img src="http://reviewboard.kde.org/media/uploaded/images/2010/08/13/routingwidgetPCVersion_400x100.jpeg" style="border: 1px black solid;" alt="Routing Information Widget for Desktop version of marble" /></a>
<a href="http://reviewboard.kde.org/r/5011/s/479/"><img src="http://reviewboard.kde.org/media/uploaded/images/2010/08/13/routingwidgetsmall_400x100.jpeg" style="border: 1px black solid;" alt="Routing Widget for small screen devices. This screen shot shows the routing information widget which appears on clicking "R" on the routing widget" /></a>
<a href="http://reviewboard.kde.org/r/5011/s/480/"><img src="http://reviewboard.kde.org/media/uploaded/images/2010/08/13/navigationMenuroutingsmall_400x100.jpeg" style="border: 1px black solid;" alt="navigation menu for routing widget for small screen devices" /></a>
<a href="http://reviewboard.kde.org/r/5011/s/483/"><img src="http://reviewboard.kde.org/media/uploaded/images/2010/08/15/updatedRoutingPlugin_400x100.jpeg" style="border: 1px black solid;" alt="[New]RoutingInformation for Desktop Marble" /></a>
<a href="http://reviewboard.kde.org/r/5011/s/484/"><img src="http://reviewboard.kde.org/media/uploaded/images/2010/08/15/updatedRoutingPlugin1_400x100.jpeg" style="border: 1px black solid;" alt="[new] Routing information for Small Screen Devices" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>