[Marble-devel] Review Request: Interface for Small Screen Devices

[Siddharth Srivastava]

> On 2010-08-16 19:40:40, Dennis Nienhüser wrote:
> > /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.cpp, line 390
> > <http://reviewboard.kde.org/r/5011/diff/2/?file=34041#file34041line390>
> >
> >     To be safe you should check whether showRoutingItem is called repeatedly with the same value. Currently this would result in multiple signal/slot connections, which is bad.

done


> On 2010-08-16 19:40:40, Dennis Nienhüser wrote:
> > /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.cpp, line 432
> > <http://reviewboard.kde.org/r/5011/diff/2/?file=34041#file34041line432>
> >
> >     preferably using the HOUR2MIN and other constants

done


> On 2010-08-16 19:40:40, Dennis Nienhüser wrote:
> > /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.cpp, line 481
> > <http://reviewboard.kde.org/r/5011/diff/2/?file=34041#file34041line481>
> >
> >     %n hours
> >     
> >     %n minutes

all similar suggestions implemented


- Siddharth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5011/#review7095
-----------------------------------------------------------


On 2010-08-17 19:48:01, Siddharth Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5011/
> -----------------------------------------------------------
> 
> (Updated 2010-08-17 19:48:01)
> 
> 
> Review request for marble and Dennis Nienhüser.
> 
> 
> Summary
> -------
> 
> An interface of Routing Plugin for Small Screen Devices is added. The Routing Plugin for Small Screen Device contains options for navigation( recenter, auto zoom), routing information widget, zoom in and zoom out functionalities.
> The routing information widget for desktop version of marble, now shows the next instruction as well as the distance remaining to reach it.
> 
> The instruction point now grows in two levels when the gps location gets closer to it instead of displaying the instruction text at it. 1) The instruction point going to be visited grows in size 2) When the gps device is at certain time away from the instruction point, it grows a bit further.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.h 1164455 
>   /trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.cpp 1164455 
>   /trunk/KDE/kdeedu/marble/src/lib/CurrentLocationWidget.ui 1164455 
>   /trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.h 1164455 
>   /trunk/KDE/kdeedu/marble/src/lib/DownloadRegionDialog.cpp 1164455 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp 1164455 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1164455 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1164455 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h 1164455 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp 1164455 
>   /trunk/KDE/kdeedu/marble/src/lib/graphicsview/ScreenGraphicsItem_p.h 1164455 
>   /trunk/KDE/kdeedu/marble/src/lib/graphicsview/WidgetGraphicsItem.h 1164455 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/AdjustNavigation.h 1164455 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/AdjustNavigation.cpp 1164455 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingLayer.cpp 1164455 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.h 1164455 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingManager.cpp 1164455 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.h 1164455 
>   /trunk/KDE/kdeedu/marble/src/lib/routing/RoutingModel.cpp 1164455 
>   /trunk/KDE/kdeedu/marble/src/marble.qrc 1164455 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/navigation/NavigationFloatItem.h 1164455 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/navigation/NavigationFloatItem.cpp 1164455 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/progress/ProgressFloatItem.h 1164455 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/CMakeLists.txt 1164455 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingInformationWidget.ui PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingInformationWidgetSmall.ui PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingItemWidget.ui 1164455 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.h 1164455 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingPlugin.cpp 1164455 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/routing/RoutingWidgetSmall.ui PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/5011/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Routing Information Widget for Desktop version of marble
>   http://reviewboard.kde.org/r/5011/s/478/
> Routing Widget for small screen devices. This screen shot shows the routing information widget which appears on clicking "R" on the routing widget
>   http://reviewboard.kde.org/r/5011/s/479/
> navigation menu for routing widget for small screen devices
>   http://reviewboard.kde.org/r/5011/s/480/
> [New]RoutingInformation for Desktop Marble
>   http://reviewboard.kde.org/r/5011/s/483/
> [new] Routing information for Small Screen Devices
>   http://reviewboard.kde.org/r/5011/s/484/
> 
> 
> Thanks,
> 
> Siddharth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100817/ce7fa8eb/attachment.htm