[Marble-devel] Review Request: Removing QPixmap from GeoData-classes

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3855/#review7053
-----------------------------------------------------------


Did this one ever get committed? Volker Lanz is now reporting that he ran into a case where he loaded KML files into Marble 0.10.0 and the command line barked about pixmaps being created in a thread ... :-/ Is this change binary compatible so that we can possibly backport it?

- Torsten


On 2010-05-07 14:47:30, Bastian Holst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3855/
> -----------------------------------------------------------
> 
> (Updated 2010-05-07 14:47:30)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> Removing QPixmap from GeoData-classes, as it is not save to be used in a thread other than the ui-thread. GeoData* are created in such a thread.
> Making GeoDataColorStyle and GeoDataIconStyle implicitly shared.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/lib/VisiblePlacemark.cpp 1123930 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataColorStyle.h 1123930 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataColorStyle.cpp 1123930 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.cpp 1123930 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataIconStyle.h 1123930 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataIconStyle.cpp 1123930 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataStyle.h 1123930 
>   trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataStyle.cpp 1123930 
> 
> Diff: http://reviewboard.kde.org/r/3855/diff
> 
> 
> Testing
> -------
> 
> Crashes on exit in ~GeoDataRegionPrivate
> 
> 
> Thanks,
> 
> Bastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100814/f0ecab66/attachment.htm