<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/3855/">http://reviewboard.kde.org/r/3855/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did this one ever get committed? Volker Lanz is now reporting that he ran into a case where he loaded KML files into Marble 0.10.0 and the command line barked about pixmaps being created in a thread ... :-/ Is this change binary compatible so that we can possibly backport it?</pre>
<br />
<p>- Torsten</p>
<br />
<p>On May 7th, 2010, 2:47 p.m., Bastian Holst wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for marble.</div>
<div>By Bastian Holst.</div>
<p style="color: grey;"><i>Updated 2010-05-07 14:47:30</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removing QPixmap from GeoData-classes, as it is not save to be used in a thread other than the ui-thread. GeoData* are created in such a thread.
Making GeoDataColorStyle and GeoDataIconStyle implicitly shared.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Crashes on exit in ~GeoDataRegionPrivate</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdeedu/marble/src/lib/VisiblePlacemark.cpp <span style="color: grey">(1123930)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataColorStyle.h <span style="color: grey">(1123930)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataColorStyle.cpp <span style="color: grey">(1123930)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataFeature.cpp <span style="color: grey">(1123930)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataIconStyle.h <span style="color: grey">(1123930)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataIconStyle.cpp <span style="color: grey">(1123930)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataStyle.h <span style="color: grey">(1123930)</span></li>
<li>trunk/KDE/kdeedu/marble/src/lib/geodata/data/GeoDataStyle.cpp <span style="color: grey">(1123930)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/3855/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>