[Marble-devel] Review Request: Online Services plugin Tutorial

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4532/#review7054
-----------------------------------------------------------

Ship it!


I think this should go into the sources. bholst: could you update it? IIRC you had a newer version for Akademy 2010 :-)

- Torsten


On 2010-07-07 13:48:11, Bastian Holst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4532/
> -----------------------------------------------------------
> 
> (Updated 2010-07-07 13:48:11)
> 
> 
> Review request for marble and Torsten Rahn.
> 
> 
> Summary
> -------
> 
> This is a request on adding the online service tutorial plugin to the Marble examples
> It is intended to be compiled seperately (so it also shows how to deliver a plugin). At the moment it installs the plugin always to the location for the kde version of Marble.
> 
> We should change FindMarble.cmake, so it supports the default plugin path.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/examples/plugins/onlineplugin/CMakeLists.txt PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/examples/plugins/onlineplugin/TutorialItem.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/examples/plugins/onlineplugin/TutorialItem.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/examples/plugins/onlineplugin/TutorialModel.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/examples/plugins/onlineplugin/TutorialModel.cpp PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/examples/plugins/onlineplugin/TutorialPlugin.h PRE-CREATION 
>   /trunk/KDE/kdeedu/marble/examples/plugins/onlineplugin/TutorialPlugin.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/4532/diff
> 
> 
> Testing
> -------
> 
> Running.
> 
> 
> Screenshots
> -----------
> 
> The output of the tutorial plugin
>   http://reviewboard.kde.org/r/4532/s/445/
> 
> 
> Thanks,
> 
> Bastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100814/52042a28/attachment.htm