[Marble-devel] Review Request: memory leaks

[Andrew Manson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1107/#review1731
-----------------------------------------------------------


My official opinion is *do not* apply the memory leak fix on the Gps layer. I have tried that exact fix 2day ago and the whole code is way to unstable to delete anything. Every time you delete anything and close a memory leak you create a crash. Do not apply this patch. Any work done on the GPX or GPS layer must be concentrated on replacement instead of fixing. 

- Andrew


On 2009-07-23 22:06:54, tgridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1107/
> -----------------------------------------------------------
> 
> (Updated 2009-07-23 22:06:54)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> FileViewFloatItem event propagation
> GpsLayer model clearing
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/GpsLayer.cpp 1001551 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/fileview/FileViewFloatItem.cpp 1001551 
> 
> Diff: http://reviewboard.kde.org/r/1107/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> tgridel
> 
>