[Marble-devel] Review Request: memory leaks

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1107/#review1729
-----------------------------------------------------------


The suggested FileViewFloatItem fix looks fine to me. I wonder though whether the FileView shouldn't get disabled from the build for Marble 0.8 (I think it only got accidently enabled but I might be wrong).

For the GpsLayer I'd like to hear Andrew's opinion. Formally the suggested fix looks ok of course.

- Torsten


On 2009-07-23 22:06:54, tgridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1107/
> -----------------------------------------------------------
> 
> (Updated 2009-07-23 22:06:54)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> FileViewFloatItem event propagation
> GpsLayer model clearing
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/GpsLayer.cpp 1001551 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/fileview/FileViewFloatItem.cpp 1001551 
> 
> Diff: http://reviewboard.kde.org/r/1107/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> tgridel
> 
>