[Marble-devel] Review Request: memory leaks

[tgridel at free.fr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1107/#review1728
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/src/lib/gps/GpsLayer.cpp
<http://reviewboard.kde.org/r/1107/#comment1122>

    Do not apply this diff on Gpslayer!!
    
    There is a leak there as the m_fileModel is a QVector that need emptying.
    
    Anyway the m_fileModel must not be deleted there as it got created in MarbleModel and we are not providing the new one back there.
    
    Unfortunately the provided patch makes a crash.


- tgridel


On 2009-07-23 22:06:54, tgridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1107/
> -----------------------------------------------------------
> 
> (Updated 2009-07-23 22:06:54)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> FileViewFloatItem event propagation
> GpsLayer model clearing
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/GpsLayer.cpp 1001551 
>   /trunk/KDE/kdeedu/marble/src/plugins/render/fileview/FileViewFloatItem.cpp 1001551 
> 
> Diff: http://reviewboard.kde.org/r/1107/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> tgridel
> 
>