D17241: WIP:Disable highlighting after 512 characters on a line.
Kåre Särs
noreply at phabricator.kde.org
Sat Jun 15 19:59:56 BST 2019
sars added a comment.
I tried the patch and it improved the performance really much! :) I was able to edit a line that contained over a million characters!
Unfortunately I can't comment on the code too much, as I don't know the code enough.
Some general stuff:
1. Should there be a warning/information-message about why the highlighting is disabled?
2. Should the line length limit be increased?
Great work!
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17241
To: cullmann, vkrause, dhaumann, mwolff, sars
Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190615/86dccdcc/attachment.html>
More information about the KWrite-Devel
mailing list