<table><tr><td style="">sars added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17241">View Revision</a></tr></table><br /><div><div><p>I tried the patch and it improved the performance really much! :) I was able to edit a line that contained over a million characters!</p>
<p>Unfortunately I can't comment on the code too much, as I don't know the code enough.</p>
<p>Some general stuff:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">Should there be a warning/information-message about why the highlighting is disabled?</li>
<li class="remarkup-list-item">Should the line length limit be increased?</li>
</ol>
<p>Great work!</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17241">https://phabricator.kde.org/D17241</a></div></div><br /><div><strong>To: </strong>cullmann, vkrause, dhaumann, mwolff, sars<br /><strong>Cc: </strong>zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann<br /></div>