D18083: Search plugin: Extend tooltip for the Regular Expressions switch

[Dominik Haumann]

dhaumann added a comment.


  Patch looks interesting, didn't know about http://doc.qt.io/qt-5/qlineedit.html#addAction eith TrailingPosition.

INLINE COMMENTS

> plugin_search.cpp:97
> +
> +    actionPointers << menuEntry(menu, QStringLiteral("\\n"), QStringLiteral(""), i18n("Line break"));
> +    actionPointers << menuEntry(menu, QStringLiteral("\\t"), QStringLiteral(""), i18n("Tab"));

An empty QStringLiteral should always be a simple QString().

> sars wrote in plugin_search.cpp:461
> Note that this icon is not available with gnome icon theme. you need to specify that Kate depends on Breeze icon theme and actually have it installed to get this icon...

A solution is to use the overload with a fallback: if the icon is not found, use a more generic one that at least exists. See:
http://doc.qt.io/qt-5/qicon.html#fromTheme-1

More so, the concept of fallback themes was introduced for 5.12 to address this as well, see: http://doc.qt.io/qt-5/qicon.html#setFallbackThemeName

Probably not applicable here, though.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D18083

To: gregormi, #kate
Cc: dhaumann, loh.tar, sars, kwrite-devel, hase, michaelh, ngraham, demsking, cullmann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190113/595af5f3/attachment.html>