D18164: Review KateGotoBar

Christoph Cullmann noreply at phabricator.kde.org
Fri Jan 11 07:20:03 GMT 2019

cullmann added inline comments.


> anthonyfieroni wrote in katedialogs.cpp:1130
> > you can either cumulatively add the delta values from events until the value of 120 is reached
> I don't know what is unclear, it should be 120 not any other value.
>   if (object == m_ModifiedUp) {
>       m_deltaUp += event->delta();
>       if (m_deltaUp >= 120) {
>           m_ModifiedUp->click();
>   }
> and so on. If not do it right you can end up in partial value when it used finer-resolution wheels and mishmash.

I think 120 would be better to use, as that is the value one should start to handle given the docs.
I would not use a static delta but just have the delta as member of the class.

  R39 KTextEditor


To: loh.tar, #ktexteditor
Cc: cullmann, anthonyfieroni, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190111/37da962b/attachment.html>

More information about the KWrite-Devel mailing list