D18164: Review KateGotoBar

loh tar noreply at phabricator.kde.org
Fri Jan 11 14:42:01 GMT 2019


loh.tar updated this revision to Diff 49243.
loh.tar added a comment.


  - Use 120 as wheel-delta threshold
  - Use member instead of static local
  
  > If not do it right you can end up in partial value when it used finer-resolution wheels and mishmash.
  
  I have problems to see that hazard, na matter.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18164?vs=49185&id=49243

REVISION DETAIL
  https://phabricator.kde.org/D18164

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/katedialogs.h

To: loh.tar, #ktexteditor
Cc: cullmann, anthonyfieroni, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190111/90544c70/attachment.html>


More information about the KWrite-Devel mailing list