D18164: Review KateGotoBar

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> loh.tar wrote in katedialogs.cpp:1130
> > It should be 120,
> 
> Why? Have now read the doc, but without a new insight.
> 
> > also you can have 2 separate delta members
> 
> How and why?

> you can either cumulatively add the delta values from events until the value of 120 is reached

I don't know what is unclear, it should be 120 not any other value.

  if (object == m_ModifiedUp) {
      m_deltaUp += event->delta();
      if (m_deltaUp >= 120) {
          m_ModifiedUp->click();
  }

and so on. If not do it right you can end up in partial value when it used finer-resolution wheels and mishmash.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18164

To: loh.tar, #ktexteditor
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190111/9fa5c7a9/attachment.html>