D18164: Review KateGotoBar

[loh tar]

loh.tar added a comment.


  I was about to move StatusBarButton into kateviewhelpers, so that this button can used elsewhere too, like here. But got stuck. However, I think such button would be handy. Perhaps also a  KateViewBarLayout. 
  Here shot regarding 'Change label text to be less redundant in conjunction with the "goto-button"' At least in German is that old text terrible.
  F6539614: 1547187451.png <https://phabricator.kde.org/F6539614>

INLINE COMMENTS

> anthonyfieroni wrote in katedialogs.cpp:1130
> https://doc.qt.io/qt-5/qwheelevent.html#angleDelta
> It should be 120, also you can have 2 separate delta members

> It should be 120,

Why? Have now read the doc, but without a new insight.

> also you can have 2 separate delta members

How and why?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18164

To: loh.tar, #ktexteditor
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190111/b58b37e2/attachment-0001.html>