D16926: Review user interaction in session management

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> katesessionmanagedialog.cpp:68-69
>  
> -    m_rename = new QPushButton(i18n("&Rename..."));
> -    connect(m_rename, SIGNAL(clicked()), this, SLOT(rename()));
> -    rightButtons->addButton(m_rename, QDialogButtonBox::ApplyRole);
> +    //KGuiItem::assign(m_renameButton, KStandardGuiItem::rename()); // Missing
> +    //KGuiItem::assign(m_renameButton, KStandardGuiItem::configure()); // Looks odd
> +    connect(m_renameButton, &QPushButton::clicked, this, &KateSessionManageDialog::editBegin);

Especially this comments should go away.

> katesessionmanagedialog.cpp:118
> +            m_sortButton->setText(i18n("Sort Last Used"));
> +            //m_sortButton->setIcon(QIcon::fromTheme(QStringLiteral("FIXME")));
> +            break;

Debug messages also go out. It's kind of info before you ship it.

> katesessionmanagedialog.cpp:496-499
> +//         if (    event->type() != QEvent::Paint
> +//              && event->type() != QEvent::HoverMove ) {
> +//                 qDebug() << event;
> +//             }

Also don't commit commented code.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D16926

To: loh.tar, #kate, dhaumann, ngraham, #vdg
Cc: anthonyfieroni, cullmann, kwrite-devel, #kate, michaelh, ngraham, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181126/1bf7ded0/attachment-0001.html>