D16926: Review user interaction in session management

Nathaniel Graham noreply at phabricator.kde.org
Mon Nov 26 04:30:23 GMT 2018

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.

  When submitting patches that change the UI, please add #VDG <https://phabricator.kde.org/tag/vdg/> as a reviewer and put screenshots in the Test Plan section rather than in a comment, where they will get buried :)
  Here are a few things that jump out at me:
  - The Sort Alphabetical button should be a combobox with the different sorting options
  - It's not clear what the New Anonymous and Open as Template buttons do, or the Don't ask again checkbox. What's being asked?
  - "Copy As..." would be better worded as "Duplicate..."
  - The Close button should probably be renamed "Select" or "Choose" so it's clear that the selected session will be made the active one
  - The bottom-most button should be aligned to the bottom of the list box, as @cullmann suggested

  R40 Kate


To: loh.tar, #kate, dhaumann, ngraham, #vdg
Cc: anthonyfieroni, cullmann, kwrite-devel, #kate, michaelh, ngraham, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181126/81a24e2f/attachment.html>

More information about the KWrite-Devel mailing list