D17459: SearchBar: Add Cancel button to stop long running tasks

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> katesearchbar.cpp:860-865
> +    d(this)->m_inputRange = inputRange;
> +    d(this)->m_workingRange = m_view->doc()->newMovingRange(d(this)->m_inputRange);
> +    d(this)->m_replacement = replacement;
> +    d(this)->m_replaceMode = replaceMode;
> +    d(this)->m_matchCounter = 0;
> +    d(this)->m_cancelFindOrReplace = false; // Ensure we have a GO!

Maybe not an issue, but you can try to cache value preventing unwanted lookup

  auto dd = d(this);
  dd->...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181221/dc102a28/attachment-0001.html>