D17459: SearchBar: Add Cancel button to stop long running tasks

[loh tar]

loh.tar added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in katesearchbar.cpp:860-865
> Maybe not an issue, but you can try to cache value preventing unwanted lookup
> 
>   auto dd = d(this);
>   dd->...

Only here or everywhere?
At this particular place may that optimized by the compiler(?)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181221/d4563ab6/attachment.html>