D17314: Projects Plugin: Add ShellCheck analyser

[gregormi]

gregormi added inline comments.

INLINE COMMENTS

> kfunk wrote in kateprojectcodeanalysistool.h:98
> This looks overly complicated and limited for an interface to me.
> 
> Why not something like `bool isSuccessfulRC(int rc) const`?
> 
> Default impl: `return rc == 0;`

Bought! Your suggestion is easier to understand while being more flexible.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D17314

To: gregormi, #kate
Cc: kfunk, kwrite-devel, hase, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181203/46da725e/attachment.html>