D17314: Projects Plugin: Add ShellCheck analyser

[Dominik Haumann]

dhaumann added a comment.


  I think Kevin's suggestion is a good one. One more iteration?

INLINE COMMENTS

> kateprojectcodeanalysistoolshellcheck.cpp:88
> +
> +    QRegExp regex(QStringLiteral("([^:]+):(\\d+):\\d+: (\\w+): (.*)"));
> +    regex.indexIn(line);

QRegExp is deprecated in favor of QRegeularExplression. Could you replace this?
If you want to save time by avoiding creating the QRegularExpression every time parseLine() is called, you can make it static: static QRegularExpression regex(...);

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D17314

To: gregormi, #kate
Cc: dhaumann, kfunk, kwrite-devel, hase, michaelh, ngraham, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181203/0d1d0788/attachment-0001.html>