D17314: Projects Plugin: Add ShellCheck analyser

[Kevin Funk]

kfunk added a comment.


  Just my 2 cent when I saw this review, didn't look further :)

INLINE COMMENTS

> kateprojectcodeanalysistool.h:98
> +     */
> +    virtual int successfulExitCodeIsLessOrEqual();
> +

This looks overly complicated and limited for an interface to me.

Why not something like `bool isSuccessfulRC(int rc) const`?

Default impl: `return rc == 0;`

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D17314

To: gregormi, #kate
Cc: kfunk, kwrite-devel, hase, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181203/23a9fea3/attachment.html>