D21076: ICC Color Correction Effect

[Vitaliy Filippov]

vitaliyf added a comment.


  In D21076#676555 <https://phabricator.kde.org/D21076#676555>, @rjvbb wrote:
  
  > > As I understand 3rdparty binary effects are harder to install, very unpopular and it will take 100 years to get it packaged in all distros...
  >
  > It should be possible to package this as an add-on desktop effect that people can install at will:
  >  F9381278: image.png <https://phabricator.kde.org/F9381278>
  
  
  Is it? How does it work? It definitely requires distribution of a binary addon. Does KDE installer build binary addons?
  
  > My guess would be that the greyscale effect has very similar requirements (it's basically a hardwired colour correction profile, no?)
  
  As I understand grayscale effect is built into KWin and all the 3rdparty addon has to do is to enable it via JS code, which is not the case with ICC.
  
  > Your fix seems to work, but I continue to get annoying update glitches, mostly when switching between virtual desktops (for which I don't use any transition effects):
  >  F9381344: image.png <https://phabricator.kde.org/F9381344>
  >  I get them too (but much less severe) in xfwm4 (4.12.x) with composition enabled so this may be a manifestation of the apparently shitty Intel i915 driver (on this machine I have to stick to the 4.14 kernel because later versions tend to hang the GPU >:( )
  
  I get similar glitches too. They don't reproduce always, but I feel they tend to "accumulate" over time. Sometimes I just restart kwin with `kwin --replace`...
  Problem is that I have little to no knowledge about OpenGL and kwin rendering pipeline, so the code is mostly written by guess :)
  The whole idea is to generate a texture and run pixels through it. I use GL_TEXTURE3...
  I'd appreciate if you could give me some advice on how I should deal with that texture. Maybe I bind it incorrectly or maybe I don't clear some bindings or maybe something else...?
  
  > But kWin also causes an update issue in Konsole when compositing is enabled, where the last line shows the previous command instead of the prompt. I do have a dynamic shell prompt set up that echoes the last command I executed whenever I hit Enter
  
  I had this problem at some point and I don't remember how exactly I solved it. I remember that it definitely wasn't caused just by my effect though.
  
  One recent thing that I remember is Mesa 20 switching to the Intel "iris" driver by default which is still buggy and leads to all kinds of glitches with KWin. Try to switch to the older stable driver by adding MESA_LOADER_DRIVER_OVERRIDE=i965 to /etc/environment ...

REVISION DETAIL
  https://phabricator.kde.org/D21076

To: vitaliyf, zzag, rjvbb
Cc: knechtges, rjvbb, graesslin, davidedmundson, zzag, ngraham, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20201006/300ac933/attachment.htm>