D21076: ICC Color Correction Effect

[René J.V. Bertin]

rjvbb added a comment.


  > As I understand 3rdparty binary effects are harder to install, very unpopular and it will take 100 years to get it packaged in all distros...
  
  It should be possible to package this as an add-on desktop effect that people can install at will:
  F9381278: image.png <https://phabricator.kde.org/F9381278>
  
  My guess would be that the greyscale effect has very similar requirements (it's basically a hardwired colour correction profile, no?)
  
  Your fix seems to work, but I continue to get annoying update glitches, mostly when switching between virtual desktops (for which I don't use any transition effects):
  F9381344: image.png <https://phabricator.kde.org/F9381344>
  I get them too (but much less severe) in xfwm4 (4.12.x) with composition enabled so this may be a manifestation of the apparently shitty Intel i915 driver (on this machine I have to stick to the 4.14 kernel because later versions tend to hang the GPU >:( )
  But kWin also causes an update issue in Konsole when compositing is enabled, where the last line shows the previous command instead of the prompt. I do have a dynamic shell prompt set up that echoes the last command I executed whenever I hit Enter 
  F9381365: image.png <https://phabricator.kde.org/F9381365>
  but the prompt should still show as in this snapshot. Moving the mouse around tends to fix all those glitches so it looks like graphics operations remain pending. I hoped it could be the VSync tearing prevention but I still get the same glitches with that turned off.
  
  Much as I appreciate the colour correction I probably will go back to xfwm4 because it glitches less (and is also much less resource hungry).

REVISION DETAIL
  https://phabricator.kde.org/D21076

To: vitaliyf, zzag, rjvbb
Cc: knechtges, rjvbb, graesslin, davidedmundson, zzag, ngraham, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20201006/daab80a7/attachment.htm>