D24461: Fix coding style issues in Scene::paintSimpleScreen
Vlad Zahorodnii
noreply at phabricator.kde.org
Tue Oct 29 15:49:12 GMT 2019
zzag added inline comments.
INLINE COMMENTS
> romangg wrote in scene.cpp:281
> auto *cc =...
>
> const?
>
> No qobject_cast here?
> No qobject_cast here?
I would be in favor of using qobject_cast for casting QObjects all over kwin, however switching from dynamic_cast to qobject_cast doesn't really align with this patch.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D24461
To: zzag, #kwin, romangg
Cc: romangg, fredrik, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191029/4b11a0c7/attachment.html>
More information about the kwin
mailing list