D24461: Fix coding style issues in Scene::paintSimpleScreen

Roman Gilg noreply at phabricator.kde.org
Tue Oct 29 15:37:14 GMT 2019


romangg accepted this revision.
romangg added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> scene.cpp:277
> +        if (window->isOpaque()) {
> +            AbstractClient *client = dynamic_cast<AbstractClient *>(toplevel);
> +            if (client) {

auto *client =....

> scene.cpp:281
>              }
> -            X11Client *cc = dynamic_cast<X11Client *>(c);
> +            X11Client *cc = dynamic_cast<X11Client *>(client);
>              // the window is fully opaque

auto *cc =...

const?

No qobject_cast here?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D24461

To: zzag, #kwin, romangg
Cc: romangg, fredrik, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191029/8259ee97/attachment-0001.html>


More information about the kwin mailing list