D22150: [plugins/qpa] Implement native offscreen surface

[Roman Gilg]

romangg added a comment.


  I would put the code split up into the egl_helpers file into a separate commit. Other than that looks nice. Wondering why we didn't have this implemented before and it wasn't an issue before 5.16.

INLINE COMMENTS

> sharingplatformcontext.cpp:98
> +        EGLSurface eglSurface = static_cast<OffscreenSurface *>(surface)->nativeHandle();
> +        const bool ok = eglSwapBuffers(eglDisplay(), eglSurface);
> +        if (!ok) {

pbuffers only have a back buffer and eglSwapBuffers is a no-op.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22150

To: zzag, #kwin
Cc: romangg, alexeymin, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190628/9f1baedc/attachment.html>