D22150: [plugins/qpa] Implement native offscreen surface

[Alexey Min]

alexeymin added inline comments.

INLINE COMMENTS

> egl_helpers.cpp:70
> +    if (!eglChooseConfig(display, attributes.data(), configs, 1, &configCount)) {
> +        // FIXME: Don't bail out yet, we should try to find the most suitable config.
> +        qCWarning(KWIN_QPA, "eglChooseConfig failed: %x", eglGetError());

This reminds me of what I did in D11758 <https://phabricator.kde.org/D11758> ... maybe if qpa also needs to be smart about this, the code from that revision could be refactored into a separate function and used here? Attributes were filled in differently there though. Mybe this code already has more restrictions to config attrs and always chooses right.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22150

To: zzag, #kwin
Cc: alexeymin, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190628/a4d8ff31/attachment-0001.html>