D22150: [plugins/qpa] Implement native offscreen surface

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> alexeymin wrote in egl_helpers.cpp:70
> This reminds me of what I did in D11758 <https://phabricator.kde.org/D11758> ... maybe if qpa also needs to be smart about this, the code from that revision could be refactored into a separate function and used here? Attributes were filled in differently there though. Mybe this code already has more restrictions to config attrs and always chooses right.

No, this FIXME comment talks about finding the most suitable config, i.e. with different attributes.

> romangg wrote in sharingplatformcontext.cpp:98
> pbuffers only have a back buffer and eglSwapBuffers is a no-op.

Yeah, perhaps we don't need it. QOffscreenSurface is used only to create rendering resources.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22150

To: zzag, #kwin
Cc: romangg, alexeymin, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190628/bcbabf5e/attachment-0001.html>