[Kstars-devel] Review Request 113409: Fixed bug related to position and detail of KSComet object

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113409/#review43484
-----------------------------------------------------------


This review has been submitted with commit b2a5142060f20b8f26855719eb259c8d99dc9485 by Jasem Mutlaq to branch KDE/4.12.

- Commit Hook


On Oct. 23, 2013, 9:25 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113409/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 9:25 p.m.)
> 
> 
> Review request for KStars, Samikshan Bairagya, Henry de Valence, Rafal Kulaga, and Rishab Arora.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Bug:
> -> On finding comet object from find object blank screen appears (because calculation sets both ra/dec to NaN). Image attached. 
> -> On seeing detail of comet from findObjectDialog it saws "comet in unknown" and distance 0 AU in general tab and all field in position tab are either default value or garbage number (image attached).
> 
> Bug Fixing:
> -> Added missing code for calculation of heliocentric cartesian coords in KSComet::findGeocentricPosition() and set value of the same.
> 
> Code cleaning:
> -> Removed unused variable QFile file, QString line, QStringList fields and bool ok from class CometsComponent. 
> 
> 
> Diffs
> -----
> 
>   kstars/skyobjects/kscomet.cpp 22d2c45 
>   kstars/skycomponents/cometscomponent.cpp 395c856 
> 
> Diff: http://git.reviewboard.kde.org/r/113409/diff/
> 
> 
> Testing
> -------
> 
> Bug fixed
> 
> 
> File Attachments
> ----------------
> 
> comet_bug.png
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/23/4c33317e-51fa-44e8-8ace-cf3eac8d01ab__comet_bug.png
> comet_bug_gen_detail.png
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/23/73d82434-cfb9-43ae-8683-d817c0c02af1__comet_bug_gen_detail.png
> comet_bug_pos_detail.png
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/23/cdd96327-4b3e-4d77-b824-5c27ccd67796__comet_bug_pos_detail.png
> comet_bug_gen_detail_fixed.png
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/23/24acba69-e06a-4ac7-bb7b-21748fb521f7__comet_bug_gen_detail_fixed.png
> comet_bug_pos_detail_fixed.png
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/23/7c2e06cc-43ac-42dd-bbab-dc10ee2288dd__comet_bug_pos_detail_fixed.png
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20131112/575c2fda/attachment.html>