<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113409/">http://git.reviewboard.kde.org/r/113409/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit b2a5142060f20b8f26855719eb259c8d99dc9485 by Jasem Mutlaq to branch KDE/4.12.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On October 23rd, 2013, 9:25 p.m. UTC, Vijay Dhameliya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KStars, Samikshan Bairagya, Henry de Valence, Rafal Kulaga, and Rishab Arora.</div>
<div>By Vijay Dhameliya.</div>
<p style="color: grey;"><i>Updated Oct. 23, 2013, 9:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bug:
-> On finding comet object from find object blank screen appears (because calculation sets both ra/dec to NaN). Image attached.
-> On seeing detail of comet from findObjectDialog it saws "comet in unknown" and distance 0 AU in general tab and all field in position tab are either default value or garbage number (image attached).
Bug Fixing:
-> Added missing code for calculation of heliocentric cartesian coords in KSComet::findGeocentricPosition() and set value of the same.
Code cleaning:
-> Removed unused variable QFile file, QString line, QStringList fields and bool ok from class CometsComponent. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bug fixed</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/skyobjects/kscomet.cpp <span style="color: grey">(22d2c45)</span></li>
<li>kstars/skycomponents/cometscomponent.cpp <span style="color: grey">(395c856)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113409/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/23/4c33317e-51fa-44e8-8ace-cf3eac8d01ab__comet_bug.png">comet_bug.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/23/73d82434-cfb9-43ae-8683-d817c0c02af1__comet_bug_gen_detail.png">comet_bug_gen_detail.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/23/cdd96327-4b3e-4d77-b824-5c27ccd67796__comet_bug_pos_detail.png">comet_bug_pos_detail.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/23/24acba69-e06a-4ac7-bb7b-21748fb521f7__comet_bug_gen_detail_fixed.png">comet_bug_gen_detail_fixed.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/23/7c2e06cc-43ac-42dd-bbab-dc10ee2288dd__comet_bug_pos_detail_fixed.png">comet_bug_pos_detail_fixed.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>