[Kstars-devel] Review Request 113394: Setting alt/az from ra/dec for supernova object while loading data and solve bug 326466

[Vijay Dhameliya]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113394/
-----------------------------------------------------------

(Updated Nov. 11, 2013, 9:50 p.m.)


Status
------

This change has been marked as submitted.


Review request for KStars, Samikshan Bairagya, Henry de Valence, and Rafal Kulaga.


Bugs: 326466
    http://bugs.kde.org/show_bug.cgi?id=326466


Repository: kstars


Description
-------

While loading data from file, only ra/dec for supernova object are set which leads in error when alt/az of constellation objects are used without call to SkyPoint:EquatorialToHorizontal() (attached bug is one example in which skyObject->alt().radians() is called from Projector::toScreenVec() and alt for supernovae is not set yet so it leads to error). To avoid such scenario alt/az of supernova object are set while loading it to SupernovaeComponent.

Removed unused variables line and fields. 


Diffs
-----

  kstars/skycomponents/supernovaecomponent.cpp 157b319 

Diff: http://git.reviewboard.kde.org/r/113394/diff/


Testing
-------

Bug fixed


File Attachments
----------------

supernovae_bug.png
  http://git.reviewboard.kde.org/media/uploaded/files/2013/10/22/d32a12e2-cd06-4db3-b7e2-9687c4b264cc__supernovae_bug.png
supernovae_bug_fixed.png
  http://git.reviewboard.kde.org/media/uploaded/files/2013/10/22/d390eb44-9058-41e5-9640-3ea39f1bf679__supernovae_bug_fixed.png


Thanks,

Vijay Dhameliya

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20131111/ecf6f84a/attachment-0001.html>