[Kstars-devel] Review Request: My entire GSoC work till now. What's Interesting works for planets, bright stars and constellations now.

[Rafal Kulaga]

> On Aug. 2, 2012, 7:25 p.m., Rafal Kulaga wrote:
> > kstars/tools/whatsinteresting/modelmanager.cpp, line 71
> > <http://git.reviewboard.kde.org/r/105481/diff/2/?file=75508#file75508line71>
> >
> >     Use enum values instead of integers, it's more readable.
> 
> Samikshan Bairagya wrote:
>     Should I be using (int)SkyObject::Type instead?

Nope, use SkyObject::TYPE enum values, e.g. SkyObject::OPEN_CLUSTER instead of 3.


> On Aug. 2, 2012, 7:25 p.m., Rafal Kulaga wrote:
> > kstars/data/PlanetFacts.dat, line 1
> > <http://git.reviewboard.kde.org/r/105481/diff/2/?file=75499#file75499line1>
> >
> >     So, we're sure that we can use those descriptions?
> 
> Samikshan Bairagya wrote:
>     I think so.

Could you remind me, from where did you get them?


> On Aug. 2, 2012, 7:25 p.m., Rafal Kulaga wrote:
> > kstars/tools/whatsinteresting/skyobjitem.cpp, line 48
> > <http://git.reviewboard.kde.org/r/105481/diff/2/?file=75523#file75523line48>
> >
> >     Format your code consistently.

But I do mean that! :-) I still can find multiple examples of inconsistent formatting in your code.


- Rafal


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105481/#review16801
-----------------------------------------------------------


On July 31, 2012, 10:21 a.m., Samikshan Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105481/
> -----------------------------------------------------------
> 
> (Updated July 31, 2012, 10:21 a.m.)
> 
> 
> Review request for KStars, Rafal Kulaga and Akarsh Simha.
> 
> 
> Description
> -------
> 
> QML user interface for testing purpose ready. This shows planets, bright stars, constellations and deep-sky object. Description not yet available for bright stars and constellations. The details-view is not ready for DSOs. Also the list of DSOs displayed is not the filtered or interesting list.
> 
> 
> Diffs
> -----
> 
>   kstars/CMakeLists.txt 8c228de 
>   kstars/data/CMakeLists.txt 0dc591b 
>   kstars/data/Interesting.dat PRE-CREATION 
>   kstars/data/PlanetFacts.dat PRE-CREATION 
>   kstars/kstars.h c9e4261 
>   kstars/kstars.cpp 02661bb 
>   kstars/kstarsactions.cpp d2260ef 
>   kstars/kstarsinit.cpp 5bcefa2 
>   kstars/kstarsui-indi.rc d5a038a 
>   kstars/kstarsui-win.rc eb23e82 
>   kstars/kstarsui.rc ee56cf3 
>   kstars/tools/whatsinteresting/modelmanager.h PRE-CREATION 
>   kstars/tools/whatsinteresting/modelmanager.cpp PRE-CREATION 
>   kstars/tools/whatsinteresting/obsconditions.h PRE-CREATION 
>   kstars/tools/whatsinteresting/obsconditions.cpp PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/Button.qml PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/CMakeLists.txt PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/cluster.jpg PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/constellation.jpg PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/dso.jpg PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/galaxy.jpg PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/nebula.jpg PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/planets.jpg PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/stars.jpg PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/stripes.png PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/wiview.qml PRE-CREATION 
>   kstars/tools/whatsinteresting/skyobjitem.h PRE-CREATION 
>   kstars/tools/whatsinteresting/skyobjitem.cpp PRE-CREATION 
>   kstars/tools/whatsinteresting/skyobjlistmodel.h PRE-CREATION 
>   kstars/tools/whatsinteresting/skyobjlistmodel.cpp PRE-CREATION 
>   kstars/tools/whatsinteresting/wiusersettings.h PRE-CREATION 
>   kstars/tools/whatsinteresting/wiusersettings.cpp PRE-CREATION 
>   kstars/tools/whatsinteresting/wiusersettings.ui PRE-CREATION 
>   kstars/tools/whatsinteresting/wiview.h PRE-CREATION 
>   kstars/tools/whatsinteresting/wiview.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105481/diff/
> 
> 
> Testing
> -------
> 
> Testing done for planets, constellations, bright stars. Details-view not yet ready for DSOs.
> 
> 
> Thanks,
> 
> Samikshan Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20120805/697882b7/attachment.html>