<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105481/">http://git.reviewboard.kde.org/r/105481/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 2nd, 2012, 7:25 p.m., <b>Rafal Kulaga</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105481/diff/2/?file=75499#file75499line1" style="color: black; font-weight: bold; text-decoration: underline;">kstars/data/PlanetFacts.dat</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Mercury::Mercury is the innermost of the eight planets in the Solar System. It is also the smallest, and its orbit has the highest eccentricity of the eight. It orbits the Sun once in about 88 Earth days, completing three rotations about its axis for every two orbits. Mercury has the smallest axial tilt of the Solar System planets. The perihelion of Mercury's orbit precesses around the Sun at an excess of 43 arcseconds per century beyond what is predicted by Newtonian mechanics, a phenomenon that was explained in the 20th century by Albert Einstein's General Theory of Relativity. Mercury, being an inferior planet, appears as a morning star and an evening star, but is much more difficult to see than the other inferior planet, Venus. At its brightest, Mercury is technically a very bright object when viewed from Earth, but it is not easily seen in practice because of its proximity in the sky to the Sun.</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So, we're sure that we can use those descriptions?</pre>
</blockquote>
<p>On August 5th, 2012, 9:56 a.m., <b>Samikshan Bairagya</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think so.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you remind me, from where did you get them?</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 2nd, 2012, 7:25 p.m., <b>Rafal Kulaga</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105481/diff/2/?file=75508#file75508line71" style="color: black; font-weight: bold; text-decoration: underline;">kstars/tools/whatsinteresting/modelmanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ModelManager::updateModels()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">71</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">o</span><span class="o">-></span><span class="n">type</span><span class="p">()</span> <span class="o">==</span> <span class="mi">3</span> <span class="o">||</span> <span class="n">o</span><span class="o">-></span><span class="n">type</span><span class="p">()</span> <span class="o">==</span> <span class="mi">4</span> <span class="o">||</span> <span class="n">o</span><span class="o">-></span><span class="n">type</span><span class="p">()</span> <span class="o">==</span> <span class="mi">14</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use enum values instead of integers, it's more readable.</pre>
</blockquote>
<p>On August 5th, 2012, 9:56 a.m., <b>Samikshan Bairagya</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should I be using (int)SkyObject::Type instead?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nope, use SkyObject::TYPE enum values, e.g. SkyObject::OPEN_CLUSTER instead of 3.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 2nd, 2012, 7:25 p.m., <b>Rafal Kulaga</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105481/diff/2/?file=75523#file75523line48" style="color: black; font-weight: bold; text-decoration: underline;">kstars/tools/whatsinteresting/skyobjitem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">SkyObjItem::SkyObjItem(SkyObject* sobj, QObject* parent) : QObject(parent),</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">48</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setPosition</span><span class="p">(</span><span class="n">so</span><span class="o">=</span><span class="n">sobj</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Format your code consistently.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But I do mean that! :-) I still can find multiple examples of inconsistent formatting in your code.</pre>
<br />
<p>- Rafal</p>
<br />
<p>On July 31st, 2012, 10:21 a.m., Samikshan Bairagya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KStars, Rafal Kulaga and Akarsh Simha.</div>
<div>By Samikshan Bairagya.</div>
<p style="color: grey;"><i>Updated July 31, 2012, 10:21 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QML user interface for testing purpose ready. This shows planets, bright stars, constellations and deep-sky object. Description not yet available for bright stars and constellations. The details-view is not ready for DSOs. Also the list of DSOs displayed is not the filtered or interesting list.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing done for planets, constellations, bright stars. Details-view not yet ready for DSOs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/CMakeLists.txt <span style="color: grey">(8c228de)</span></li>
<li>kstars/data/CMakeLists.txt <span style="color: grey">(0dc591b)</span></li>
<li>kstars/data/Interesting.dat <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/data/PlanetFacts.dat <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/kstars.h <span style="color: grey">(c9e4261)</span></li>
<li>kstars/kstars.cpp <span style="color: grey">(02661bb)</span></li>
<li>kstars/kstarsactions.cpp <span style="color: grey">(d2260ef)</span></li>
<li>kstars/kstarsinit.cpp <span style="color: grey">(5bcefa2)</span></li>
<li>kstars/kstarsui-indi.rc <span style="color: grey">(d5a038a)</span></li>
<li>kstars/kstarsui-win.rc <span style="color: grey">(eb23e82)</span></li>
<li>kstars/kstarsui.rc <span style="color: grey">(ee56cf3)</span></li>
<li>kstars/tools/whatsinteresting/modelmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/modelmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/obsconditions.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/obsconditions.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/Button.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/cluster.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/constellation.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/dso.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/galaxy.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/nebula.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/planets.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/stars.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/stripes.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/wiview.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/skyobjitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/skyobjitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/skyobjlistmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/skyobjlistmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/wiusersettings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/wiusersettings.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/wiusersettings.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/wiview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/wiview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105481/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>