[Kstars-devel] KDE/kdeedu/kstars/kstars/indi

[Ralf Habacker]

Jason Harris schrieb:
> Hi Ralf,
>
> I'm still having the same errors in indicom.c, which I have attached
> to this email.  Again, adding "#include <termios.h>" to indicom.c
> resolves these errors.  Can you please have another look?
>
> thanks,
> Jason
>
> Ralf Habacker wrote:
>> Jason Harris schrieb:
>>> SVN commit 614947 by harris:
>>>
>>> Fix compile.  The new cfitsio shared lib needs to be linked against
>>> libm.  Also, there's something wrong with this #ifdef wrapper in
>>> indicom.h:
>>>
>>> #ifdef HAVE_TERMIOS_H
>>> #include <termios.h>
>>> #endif
>>>
>>> I have termios.h, but it isn't being included by the above code. 
>>> This is on Linux (gentoo).    As a workaround, I added a duplicate
>>> #include to indicom.c.  This will break compilation on w32, but I'll
>>> leave it to the windows guys to figure out what is wrong with that
>>> ifdef.
>>>
>>>   
>> There were two problems:
>> 1. HAVE_TERMIOS_H was defined in CMakeLists.txt, but not in
>> config.h.cmake -> fixed
>> 2. indicom.h does not include config.h -> fixed by including config.h
>>
>> Thanks for this pointer :-)
>>> CCMAIL: kstars-devel at kde.org
>>> CCMAIL: Ralf.Habacker at freenet.de
>>>
>>>
>>>
>>>  M  +1 -1      CMakeLists.txt   M  +3 -0      indicom.c 
>>>
>>> --- trunk/KDE/kdeedu/kstars/kstars/indi/CMakeLists.txt #614946:614947
>>> @@ -165,7 +165,7 @@
>>>  
>>>  kde4_add_library(cfitsio SHARED ${libcfitsio_SRCS})
>>>  
>>> -target_link_libraries(cfitsio)
>>> +target_link_libraries(cfitsio m)
>>>   
>> This should be limited to unix, because libm isn't available on windows.
>> Additional it looks to me that some m references are obsolate if they
>> are only there because of former static including of cfitsio sources
>>
>> Ralf
>>
>>
>
> ------------------------------------------------------------------------
>
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c: In function `tty_connect':
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:808: error: storage size of 'tty_setting' isn't known
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:817: error: `B0' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:817: error: (Each undeclared identifier is reported only once
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:817: error: for each function it appears in.)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:820: error: `B50' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:823: error: `B75' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:826: error: `B110' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:829: error: `B134' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:832: error: `B150' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:835: error: `B200' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:838: error: `B300' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:841: error: `B600' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:844: error: `B1200' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:847: error: `B1800' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:850: error: `B2400' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:853: error: `B4800' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:856: error: `B9600' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:859: error: `B19200' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:862: error: `B38400' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:865: error: `B57600' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:868: error: `B115200' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:871: error: `B230400' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:880: error: implicit declaration of function `cfsetispeed'
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:881: error: implicit declaration of function `cfsetospeed'
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:891: error: `CSIZE' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:891: error: `CSTOPB' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:891: error: `PARENB' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:891: error: `PARODD' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:891: error: `HUPCL' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:891: error: `CRTSCTS' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:892: error: `CLOCAL' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:892: error: `CREAD' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:897: error: `CS5' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:900: error: `CS6' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:903: error: `CS7' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:906: error: `CS8' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:959: error: `PARMRK' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:959: error: `ISTRIP' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:959: error: `IGNCR' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:959: error: `ICRNL' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:959: error: `INLCR' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:959: error: `IXOFF' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:959: error: `IXON' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:959: error: `IXANY' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:960: error: `INPCK' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:960: error: `IGNPAR' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:960: error: `IGNBRK' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:963: error: `OPOST' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:963: error: `ONLCR' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:968: error: `ICANON' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:968: error: `ECHO' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:968: error: `ECHOE' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:968: error: `ISIG' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:968: error: `IEXTEN' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:968: error: `NOFLSH' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:968: error: `TOSTOP' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:972: error: `VMIN' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:973: error: `VTIME' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:976: error: implicit declaration of function `tcflush'
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:976: error: `TCIOFLUSH' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:977: error: implicit declaration of function `tcsetattr'
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:977: error: `TCSANOW' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:808: warning: unused variable `tty_setting'
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c: In function `tty_disconnect':
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:996: error: `TCIOFLUSH' undeclared (first use in this function)
> make[2]: *** [kstars/kstars/CMakeFiles/kstars.dir/indi/indicom.o] Error 1
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c: In function `tty_connect':
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:808: error: storage size of 'tty_setting' isn't known
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:817: error: `B0' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:817: error: (Each undeclared identifier is reported only once
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:817: error: for each function it appears in.)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:820: error: `B50' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:823: error: `B75' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:826: error: `B110' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:829: error: `B134' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:832: error: `B150' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:835: error: `B200' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:838: error: `B300' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:841: error: `B600' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:844: error: `B1200' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:847: error: `B1800' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:850: error: `B2400' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:853: error: `B4800' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:856: error: `B9600' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:859: error: `B19200' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:862: error: `B38400' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:865: error: `B57600' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:868: error: `B115200' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:871: error: `B230400' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:880: error: implicit declaration of function `cfsetispeed'
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:881: error: implicit declaration of function `cfsetospeed'
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:891: error: `CSIZE' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:891: error: `CSTOPB' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:891: error: `PARENB' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:891: error: `PARODD' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:891: error: `HUPCL' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:891: error: `CRTSCTS' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:892: error: `CLOCAL' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:892: error: `CREAD' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:897: error: `CS5' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:900: error: `CS6' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:903: error: `CS7' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:906: error: `CS8' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:959: error: `PARMRK' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:959: error: `ISTRIP' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:959: error: `IGNCR' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:959: error: `ICRNL' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:959: error: `INLCR' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:959: error: `IXOFF' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:959: error: `IXON' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:959: error: `IXANY' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:960: error: `INPCK' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:960: error: `IGNPAR' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:960: error: `IGNBRK' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:963: error: `OPOST' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:963: error: `ONLCR' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:968: error: `ICANON' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:968: error: `ECHO' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:968: error: `ECHOE' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:968: error: `ISIG' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:968: error: `IEXTEN' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:968: error: `NOFLSH' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:968: error: `TOSTOP' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:972: error: `VMIN' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:973: error: `VTIME' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:976: error: implicit declaration of function `tcflush'
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:976: error: `TCIOFLUSH' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:977: error: implicit declaration of function `tcsetattr'
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:977: error: `TCSANOW' undeclared (first use in this function)
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:808: warning: unused variable `tty_setting'
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c: In function `tty_disconnect':
> /home/kstars/kde4svn/kdeedu/kstars/kstars/indi/indicom.c:996: error: `TCIOFLUSH' undeclared (first use in this function)
> make[2]: *** [kstars/kstars/CMakeFiles/kstars.dir/indi/indicom.o] Error 1
>   
Do you have taken a look into the generated config.h that it includes a
#define HAVE_TERMIOS_H define or at least an /* #undef TERMIOS_H */ ? 

If not there is something wrong in the configure step. Does your
config.h.cmake contains a #cmakedefine HAVE_TERMIOS_H line ?

If yes, could you remove CMakeCache.txt from the build dir and run cmake
again. Then a search for termios.h should be printed.

Ralf