[Kstars-devel] KDE/kdeedu/kstars/kstars/indi

[Jason Harris]

Hi Ralf,

I'm still having the same errors in indicom.c, which I have attached to 
this email.  Again, adding "#include <termios.h>" to indicom.c resolves 
these errors.  Can you please have another look?

thanks,
Jason

Ralf Habacker wrote:
> Jason Harris schrieb:
>> SVN commit 614947 by harris:
>>
>> Fix compile.  The new cfitsio shared lib needs to be linked against 
>> libm.  Also, there's something wrong with this #ifdef wrapper in 
>> indicom.h:
>>
>> #ifdef HAVE_TERMIOS_H
>> #include <termios.h>
>> #endif
>>
>> I have termios.h, but it isn't being included by the above code.  This 
>> is on Linux (gentoo).    As a workaround, I added a duplicate #include 
>> to indicom.c.  This will break compilation on w32, but I'll leave it to 
>> the windows guys to figure out what is wrong with that ifdef.
>>
>>   
> There were two problems:
> 1. HAVE_TERMIOS_H was defined in CMakeLists.txt, but not in
> config.h.cmake -> fixed
> 2. indicom.h does not include config.h -> fixed by including config.h
> 
> Thanks for this pointer :-)
>> CCMAIL: kstars-devel at kde.org
>> CCMAIL: Ralf.Habacker at freenet.de
>>
>>
>>
>>  M  +1 -1      CMakeLists.txt  
>>  M  +3 -0      indicom.c  
>>
>>
>> --- trunk/KDE/kdeedu/kstars/kstars/indi/CMakeLists.txt #614946:614947
>> @@ -165,7 +165,7 @@
>>  
>>  kde4_add_library(cfitsio SHARED ${libcfitsio_SRCS})
>>  
>> -target_link_libraries(cfitsio)
>> +target_link_libraries(cfitsio m)
>>   
> This should be limited to unix, because libm isn't available on windows.
> Additional it looks to me that some m references are obsolate if they
> are only there because of former static including of cfitsio sources
> 
> Ralf
> 
> 

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: kstars_errs
Url: http://mail.kde.org/pipermail/kstars-devel/attachments/20061219/6693694a/attachment.ksh