[Kst] [Kst-plot/kst] b288dc: buffer limit needs to be 64 bit

[Nicolas Brisset]

Hi Peter,

I just saw you did something about progress feedback when loading a big ASCII file. Nice :-) 
I actually had a look a couple of days ago at improved feedback when loading large documents (see roadmap, one of the long-standing open points). I added a couple of status messages in Document::open using the mainwindow statusbar, but it turned out that the dimensioning action was parsing the data (I tried it with a big ASCII file) so I thought I should add it there. I did not continue because I wasn't sure whether it was good design to add a call to a GUI item from the datasource, considering that:
1) we have a batch mode that needs to continue working  
2) the class would then be less reusable if we ever want to use if for a data converter (in Kst 1.x days we had tools to convert between supported data formats, based on data sources).

I haven't tested your change yet since I get a compile error. But one remark: in the main window there is a status bar with a hidden progress bar, maybe it would be better to use it instead of creating another widget, as I think you do from looking at the code. Check MainWindow::createStatusBar() to see what I mean.
Then we have to make sure the batch mode is no issue, and think about the possible consequences if we wanted to use that class in another pure command-line tool.

Nicolas

----- Mail original -----
> De: "Peter Kümmel" <syntheticpp at gmx.net>
> À: kst at kde.org
> Envoyé: Samedi 2 Novembre 2013 14:13:37
> Objet: [Kst] [Kst-plot/kst] b288dc: buffer limit needs to be 64 bit
> 
> Branch: refs/heads/master
>   Home:   https://github.com/Kst-plot/kst
>   Commit: b288dca2289c99b3783b2bfc2fb3226121de6b85
>       https://github.com/Kst-plot/kst/commit/b288dca2289c99b3783b2bfc2fb3226121de6b85
>   Author: Peter Kümmel <syntheticpp at gmx.net>
>   Date:   2013-11-02 (Sat, 02 Nov 2013)
> 
>   Changed paths:
>     M src/datasources/ascii/asciiconfig.ui
>     M src/datasources/ascii/asciiconfigwidget.cpp
>     M src/datasources/ascii/asciisourceconfig.cpp
>     M src/datasources/ascii/asciisourceconfig.h
>     M src/datasources/ascii/namedparameter.h
> 
>   Log Message:
>   -----------
>   buffer limit needs to be 64 bit
> 
> 
>   Commit: 1329ac8c5ccd84b08581bddfae65ac57cf784d92
>       https://github.com/Kst-plot/kst/commit/1329ac8c5ccd84b08581bddfae65ac57cf784d92
>   Author: Peter Kümmel <syntheticpp at gmx.net>
>   Date:   2013-11-02 (Sat, 02 Nov 2013)
> 
>   Changed paths:
>     M src/datasources/ascii/asciidatareader.cpp
>     M src/datasources/ascii/asciidatareader.h
>     M src/datasources/ascii/asciifiledata.cpp
>     M src/datasources/ascii/asciifiledata.h
>     M src/datasources/ascii/asciisource.cpp
>     M src/datasources/ascii/asciisource.h
> 
>   Log Message:
>   -----------
>   show progress when parsing fpr rows
> 
> 
> Compare:
> https://github.com/Kst-plot/kst/compare/1768e7cae39f...1329ac8c5ccd
> 
> _______________________________________________
> Kst mailing list
> Kst at kde.org
> https://mail.kde.org/mailman/listinfo/kst
>