[Kst] getdata

Matthew D Truch matt at truch.net
Wed Aug 22 17:56:34 CEST 2007


Greetings,

I'm not really following which branches are appropriate for such things,
but there is an open() call in getdata which doesn't follow the rule
"you must specify a mode (third argument to open()) when the flags
include O_CREAT".  (See the man page for open()).  This patch remedies
that, and allows kst to be built when some super-secret gcc anal-mode
flag is turned on (that Fedora now uses).  I made up the mode, it's
probably appropriate.  

-- 
"Things are more like they are today than they ever have been before."
--------------------------
Matthew Truch
Department of Physics and Astronomy
University of Pennsylvania
matt at truch.net
http://matt.truch.net/
-------------- next part --------------
diff -ur kst-1.4.0/kst/src/datasources/dirfile/getdata.c kst-1.4.0-fix-open/kst/src/datasources/dirfile/getdata.c
--- kst-1.4.0/kst/src/datasources/dirfile/getdata.c	2007-03-15 17:20:53.000000000 -0400
+++ kst-1.4.0-fix-open/kst/src/datasources/dirfile/getdata.c	2007-08-21 16:44:52.000000000 -0400
@@ -2204,7 +2204,7 @@
         return(1);
       }
     }else{
-      R->fp = open(datafilename, O_RDWR | O_CREAT);
+      R->fp = open(datafilename, O_RDWR | O_CREAT, 0644);
       if (R->fp < 0) {
         *n_write = 0;
         *error_code = PD_E_OPEN_RAWFIELD;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kst/attachments/20070822/4840f67e/attachment.pgp 


More information about the Kst mailing list