[Kst] Vector skip patch ?

Adam Treat treat at kde.org
Mon Oct 16 19:08:13 CEST 2006


On Monday 16 October 2006 12:04 pm, you wrote:
> Adam,
>
> Some of my colleagues (the ones who noticed the skip problem #134987 in
> the first place) are eagerly waiting for a fix as they have to deliver a
> report very soon now (!), and they are ready to try it even before it is
> officially approved. If you could send me the patch with which all tests
> pass, it would be nice for them and allow us to test it from a user's
> perspective as well...
> Thanks,
>
> Nicolas

*** DO NOT RELY ON THIS GOING IN AS IS ***

Ok, I've attached the patch, but realize that this is the minimum diff 
necessary to make rvector pass the tests.  *my tests* which have not been 
verified to be correct.  That means that this is subject to change and the 
behavior is subject to change.

Another caveat, not that this will not work for datasources that use the skip 
acceleration.  Right now, dirfile is the only datasource that this is tested 
to work for.  I'm working on a refactor of rvector at the moment while I wait 
to hear back about the testcases.  Again, things could change quickly...

*** DO NOT RELY ON THIS GOING IN AS IS ***

Adam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rvector.diff
Type: text/x-diff
Size: 2250 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kst/attachments/20061016/b4230c5d/attachment.bin 


More information about the Kst mailing list