I can build again (yay!) and found ...

Johannes Zarl-Zierl johannes at zarl-zierl.at
Sun Nov 6 22:10:46 GMT 2022


Hi,
> While running make, there are a few warnings:
> 
> In file included from
> /home/usr/src/kphotoalbum-git/kphotoalbum/Viewer/ViewerWidget.cpp:28:0:
> /home/usr/src/kphotoalbum-git/kphotoalbum/Viewer/VLCDisplay.h:33:10:warning:
> ‘virtual void Viewer::VLCDisplay::stop()’ can be marked
> override [-Wsuggest-override]
>      void stop() final;
> ^~~~

Hmm, I don't get that warning, but I see how I should get the warning as well. 
Thanks for reporting...

> /home/usr/src/kphotoalbum-git/kphotoalbum/Viewer/QtAVDisplay.cpp:In
> constructor ‘Viewer::QtAVDisplay::QtAVDisplay(QWidget*)’:
> /home/usr/src/kphotoalbum-git/kphotoalbum/Viewer/QtAVDisplay.cpp:29:47:warni
> ng: ‘constexpr QFlags<T>::QFlags(QFlags<T>::Zero) [with E
> num = Qt::WindowType; QFlags<T>::Zero = int
> QFlags<Qt::WindowType>::Private::*]’ is deprecated: Use default
> constructor instead [-Wdep
> recated-declarations]
>      m_renderer = new QtAV::WidgetRenderer(this);
> ^
[...]
> /usr/include/qt5/QtCore/qflags.h:123:80:note: declared here
>      QT_DEPRECATED_X("Use default constructor instead") Q_DECL_CONSTEXPR
> inline QFlags(Zero) noexcept : i(0) {}
> ^~~~~~

This one may be a little harder to fix for me - I'm on Debian unstable which 
does not ship libQtAV any more. If you feel like sending a merge request I 
certainly wouldn't complain ;-)
But now that I have a reason, I may just install it from source...

Cheers,
  Johannes





More information about the KPhotoAlbum mailing list