[KPhotoAlbum] Bug 150972 - change "no other" behavior when selecting directories

josephj at main.nc.us josephj at main.nc.us
Mon Feb 27 01:16:50 GMT 2012


This "no other" thing sounds interesting.  Can you point me to where and
how (if anywhere) in the user interface (not in the code) this can be
used?

Thanks.

Joe

> Hi,
>
> While digging into the mentioned bug, I reorganised the "No Others" Image
> Matcher:
>
> 0001-Replace-NoOtherCategoryMatcher-with-ExactCategoryMat.patch
> 0002-ImageSearchInfo.compile-omit-empty-andMatchers.patch
> 0003-Remove-NoOtherItemsCategoryMatcher.patch
> 0004-Remove-unused-code-from-DB-ExactCategoryMatcher.patch
>
> You can also apply this alone (which just fixes Bug 150972):
> 0005-Make-No-other-work-for-sub-categories.patch
>
> I know this is a realatively large changeset for little actual change, but
> let
> me make a stance for the new code:
>  + There is no longer a CategoryMatcher.finalize() step involved:
>    This means one less iteration over the whole matcher tree.
>  + shouldPrepareMatchedSet is only set for those parts of the matcher tree
> where it is actually needed
>  + mixing "No other" in different categories now works correctly
>   E.g.: "FolderA / **No other** / PersonB / **No other**"
>
> Cheers,
>   Johannes
> _______________________________________________
> KPhotoAlbum mailing list
> KPhotoAlbum at mail.kdab.com
> https://mail.kdab.com/mailman/listinfo/kphotoalbum
>





More information about the Kphotoalbum mailing list