[KPhotoAlbum] Bug 150972 - change "no other" behavior when selecting directories

Johannes Zarl isilmendil at gmx.net
Sun Feb 26 23:43:53 GMT 2012


Hi,

While digging into the mentioned bug, I reorganised the "No Others" Image 
Matcher:

0001-Replace-NoOtherCategoryMatcher-with-ExactCategoryMat.patch
0002-ImageSearchInfo.compile-omit-empty-andMatchers.patch
0003-Remove-NoOtherItemsCategoryMatcher.patch
0004-Remove-unused-code-from-DB-ExactCategoryMatcher.patch

You can also apply this alone (which just fixes Bug 150972):
0005-Make-No-other-work-for-sub-categories.patch

I know this is a realatively large changeset for little actual change, but let 
me make a stance for the new code:
 + There is no longer a CategoryMatcher.finalize() step involved:
   This means one less iteration over the whole matcher tree.
 + shouldPrepareMatchedSet is only set for those parts of the matcher tree 
where it is actually needed
 + mixing "No other" in different categories now works correctly
  E.g.: "FolderA / **No other** / PersonB / **No other**"

Cheers,
  Johannes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Replace-NoOtherCategoryMatcher-with-ExactCategoryMat.patch
Type: text/x-patch
Size: 8984 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kphotoalbum/attachments/20120227/dc4867a7/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ImageSearchInfo.compile-omit-empty-andMatchers.patch
Type: text/x-patch
Size: 1989 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kphotoalbum/attachments/20120227/dc4867a7/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Remove-NoOtherItemsCategoryMatcher.patch
Type: text/x-patch
Size: 9383 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kphotoalbum/attachments/20120227/dc4867a7/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Remove-unused-code-from-DB-ExactCategoryMatcher.patch
Type: text/x-patch
Size: 1448 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kphotoalbum/attachments/20120227/dc4867a7/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Make-No-other-work-for-sub-categories.patch
Type: text/x-patch
Size: 1178 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kphotoalbum/attachments/20120227/dc4867a7/attachment-0004.bin>


More information about the Kphotoalbum mailing list