[KPhotoAlbum] call for review: misc patches

[Baptiste MATHUS]

2007/5/16, Jan Kundrát <jkt at gentoo.org>:
>
> Hi,
> I have some patches that I'd like to apply. As per Jesper's suggestions,
> I'd like to hear a yes/no from mother people before I commit them and
> break stuff.
>
>
> Two trivial patches for extending the list of supported files:
>
> http://dev.gentoo.org/~jkt/tmp/bug-141877-ImageManager-recognize-erf.patch
> http://dev.gentoo.org/~jkt/tmp/bug-145366-video-flv.patch


OK for those two. I don't see any side effect it could have :-).

Make "show this image" launch viewer with *all* images form current view
> and seek to the selected one.
>
> NOTE: this will slow down viewing single image when having a lot of
> pictures displayed (not a typical situation, I guess).
>
> http://dev.gentoo.org/~jkt/tmp/bug-145309-show-this-image-shows-all.patch


I mainly reviewed this one from a user perspective. I looked a bit at the
code, apart from a typo (appers instead of appears I guess) the rest seems
correct.

I don't know KPA architecture enough to know if we'd have some way to have a
more direct access to the picture actually selected, something to avoid
scrolling to the current one.

O(n) complexity in this case would be interesting to test with a 20000 photo
db or more. If I select the last one on my 6000pix db, it's not really
annoying.

So, OK for me for this patch. At least the feature is really interesting,
and we will still be able to look for a way to improve it if necessary,
isn't it?

Annotation dialog: add button that copies tags from "previously tagged"
> image (see bugreport for details):
>
> NOTE: this also includes a fix for bug 136374. I'm not sure if I can
> touch the i18n() strings. Feel free to change the wording.
>
>
> http://dev.gentoo.org/~jkt/tmp/bug-145158-retag-with-tags-from-previous-image.patch


Haven't reviewed this one yet. So, I won't vote for the moment. Maybe
tomorrow if I find time.


> Thanks in advance,


Thanks to *you* for your work :-)


-- 
Baptiste <Batmat> MATHUS
BMathus at Batmat point net - http://batmat.net
---------
Si chacun de nous a une idée et que nous les partageons, nous
repartirons tous les deux avec deux idées... C'est ça le Libre.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kphotoalbum/attachments/20070516/665c9baa/attachment.htm>