[Konversation-devel] Review Request 120654: Add dbus method to change tray icon state

[Eike Hein]

> On Oct. 19, 2014, 9:47 a.m., Eike Hein wrote:
> > I think this isn't a good idea. Rather than patch every app under the sun, wouldn't it be much smarter if you submitted a patch to the Plasma system tray widget that allows hiding of all Active icons?
> 
> Sergio Luis Martins wrote:
>     Good idea, I'll do that too :)
>     
>     I think the two approaches are orthogonal and this patch is still good because not everybody runs Plasma on GNU/Linux, and specially not on Windows/OSX.
>     I won't patch all apps though, just the important ones, which only Konversation is missing now, if someone is using another irc client then he/she can move to Konvi :)
> 
> David Faure wrote:
>     Also, the idea is that flow-pomodoro should disable the OSD notification, right? But maybe that's already available.
> 
> Sergio Luis Martins wrote:
>     Will check, that'll be a separate commit though
> 
> Sergio Luis Martins wrote:
>     ping ?

I'm really sorry, but we're going to reject this patch - it's just not reasonable to hack this into every app on the planet. Your application is not going to scale this way. This needs to be implemented in the shell's tray visualization - even if what you want is per-app muting, then adding an API to the *shell* to mute apps by name would be better, since you just need to convince a couple of shell projects rather than potentially dozens and dozens of app teams (though there would likely be better ways, e.g. using the categorization system status notifiers already have). And there are other problems here - what if your app crashes or forgets to unmute Konversation? Then the user is stuck in a state they don't comprehend and can't easily alter. It's just not a good idea.


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120654/#review68693
-----------------------------------------------------------


On Oct. 19, 2014, 9:41 a.m., Sergio Luis Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120654/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2014, 9:41 a.m.)
> 
> 
> Review request for Konversation, David Faure and Eike Hein.
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
>     Add a way to disable tray flashing without writing to config.
>     
>     This is a D-Bus hacker option that allows to temporarily disable
>     the red icon without writing to prefs.
>     
>     Will be used in the soon to be released flow-pomodoro app that
>     disables notifications from KMail, Konversation, Pidgin etc while
>     a task is in progress. After the task ends, tray notification state
>     is restored.
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 6edb4be 
>   src/mainwindow.cpp dce9b28 
>   src/viewer/trayicon.h c2862fd 
>   src/viewer/trayicon.cpp 8eef917 
> 
> Diff: https://git.reviewboard.kde.org/r/120654/diff/
> 
> 
> Testing
> -------
> 
> Used qdbusviewer to set a Passive status, worked.
> Then enabled notifs again and icon turned red again.
> 
> 
> Thanks,
> 
> Sergio Luis Martins
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20141108/d8d0f7ac/attachment.html>