[Konversation-devel] Review Request 120654: Add dbus method to change tray icon state

[Sergio Luis Martins]

> On Oct. 19, 2014, 9:47 a.m., Eike Hein wrote:
> > I think this isn't a good idea. Rather than patch every app under the sun, wouldn't it be much smarter if you submitted a patch to the Plasma system tray widget that allows hiding of all Active icons?
> 
> Sergio Luis Martins wrote:
>     Good idea, I'll do that too :)
>     
>     I think the two approaches are orthogonal and this patch is still good because not everybody runs Plasma on GNU/Linux, and specially not on Windows/OSX.
>     I won't patch all apps though, just the important ones, which only Konversation is missing now, if someone is using another irc client then he/she can move to Konvi :)
> 
> David Faure wrote:
>     Also, the idea is that flow-pomodoro should disable the OSD notification, right? But maybe that's already available.
> 
> Sergio Luis Martins wrote:
>     Will check, that'll be a separate commit though

ping ?


- Sergio Luis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120654/#review68693
-----------------------------------------------------------


On Oct. 19, 2014, 9:41 a.m., Sergio Luis Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120654/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2014, 9:41 a.m.)
> 
> 
> Review request for Konversation, David Faure and Eike Hein.
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
>     Add a way to disable tray flashing without writing to config.
>     
>     This is a D-Bus hacker option that allows to temporarily disable
>     the red icon without writing to prefs.
>     
>     Will be used in the soon to be released flow-pomodoro app that
>     disables notifications from KMail, Konversation, Pidgin etc while
>     a task is in progress. After the task ends, tray notification state
>     is restored.
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 6edb4be 
>   src/mainwindow.cpp dce9b28 
>   src/viewer/trayicon.h c2862fd 
>   src/viewer/trayicon.cpp 8eef917 
> 
> Diff: https://git.reviewboard.kde.org/r/120654/diff/
> 
> 
> Testing
> -------
> 
> Used qdbusviewer to set a Passive status, worked.
> Then enabled notifs again and icon turned red again.
> 
> 
> Thanks,
> 
> Sergio Luis Martins
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20141103/d92c4118/attachment.html>