<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120654/">https://git.reviewboard.kde.org/r/120654/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 19th, 2014, 9:47 a.m. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think this isn't a good idea. Rather than patch every app under the sun, wouldn't it be much smarter if you submitted a patch to the Plasma system tray widget that allows hiding of all Active icons?</p></pre>
</blockquote>
<p>On October 19th, 2014, 10:03 a.m. UTC, <b>Sergio Luis Martins</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Good idea, I'll do that too :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think the two approaches are orthogonal and this patch is still good because not everybody runs Plasma on GNU/Linux, and specially not on Windows/OSX.
I won't patch all apps though, just the important ones, which only Konversation is missing now, if someone is using another irc client then he/she can move to Konvi :)</p></pre>
</blockquote>
<p>On October 19th, 2014, 3:10 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, the idea is that flow-pomodoro should disable the OSD notification, right? But maybe that's already available.</p></pre>
</blockquote>
<p>On October 23rd, 2014, 10:36 a.m. UTC, <b>Sergio Luis Martins</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Will check, that'll be a separate commit though</p></pre>
</blockquote>
<p>On November 3rd, 2014, 9:06 p.m. UTC, <b>Sergio Luis Martins</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ping ?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm really sorry, but we're going to reject this patch - it's just not reasonable to hack this into every app on the planet. Your application is not going to scale this way. This needs to be implemented in the shell's tray visualization - even if what you want is per-app muting, then adding an API to the <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">shell</em> to mute apps by name would be better, since you just need to convince a couple of shell projects rather than potentially dozens and dozens of app teams (though there would likely be better ways, e.g. using the categorization system status notifiers already have). And there are other problems here - what if your app crashes or forgets to unmute Konversation? Then the user is stuck in a state they don't comprehend and can't easily alter. It's just not a good idea.</p></pre>
<br />
<p>- Eike</p>
<br />
<p>On October 19th, 2014, 9:41 a.m. UTC, Sergio Luis Martins wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Konversation, David Faure and Eike Hein.</div>
<div>By Sergio Luis Martins.</div>
<p style="color: grey;"><i>Updated Oct. 19, 2014, 9:41 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konversation
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">Add a way to disable tray flashing without writing to config.
This is a D<span style="color: #666666">-</span>Bus hacker option that allows to temporarily disable
the red icon without writing to prefs.
Will be used in the soon to be released flow<span style="color: #666666">-</span>pomodoro app that
disables notifications from KMail, Konversation, Pidgin etc <span style="color: #008000; font-weight: bold">while</span>
a task is in progress. After the task ends, tray notification state
is restored.
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Used qdbusviewer to set a Passive status, worked.
Then enabled notifs again and icon turned red again.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/mainwindow.h <span style="color: grey">(6edb4be)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(dce9b28)</span></li>
<li>src/viewer/trayicon.h <span style="color: grey">(c2862fd)</span></li>
<li>src/viewer/trayicon.cpp <span style="color: grey">(8eef917)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120654/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>