[Konversation-devel] Review Request 109588: Handle multiple identities with the same name

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109588/#review29510
-----------------------------------------------------------


This looks like a good patch, but it could theoretically cause data loss when run against a legacy config file that uses integers as identity names ... there's two ways to handle that, either by shipping a kconf_update script (see the .upd files in the source tree for examples) that transforms the config file in the same way the code now does, or switching to using a different KConfig key name in saveOptions() and supporting both in readOptions(). 

kconf_update has proven to be shaky in practice especially without renaming keys (kded runs new .upd scripts immediately on installation time, so if a user upgrades Konvi while it's running and then quits Konvi, the saveOptions() on quits overwrites the changes - it's an annoying design flaw in kconf_update), so since there's no way around a key rename, we might as well just go for the second option ... it makes the app code a little less nice sadly, but it's just more reliable.

- Eike Hein


On March 19, 2013, 5:53 p.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109588/
> -----------------------------------------------------------
> 
> (Updated March 19, 2013, 5:53 p.m.)
> 
> 
> Review request for Konversation and Eike Hein.
> 
> 
> Description
> -------
> 
> Correct handling of multiple identities with the same name
> 
> - Identity id is used between ServerGroup dialog and Identity dialog
> - Save order is using to store the Identity of a ServerGroup
> 
> 
> This addresses bug 311300.
>     https://bugs.kde.org/show_bug.cgi?id=311300
> 
> 
> Diffs
> -----
> 
>   src/application.cpp 71e0f1f 
>   src/irc/servergroupdialog.cpp 75655b3 
> 
> Diff: http://git.reviewboard.kde.org/r/109588/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José Millán Soto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20130319/c50abc19/attachment.html>