[Konversation-devel] Review Request 109588: Handle multiple identities with the same name

José Millán Soto fid at gpul.org
Tue Mar 19 20:15:07 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109588/
-----------------------------------------------------------

(Updated March 19, 2013, 8:15 p.m.)


Review request for Konversation and Eike Hein.


Changes
-------

New version of the patch.
This time IdentityId is used as a key name.


Description
-------

Correct handling of multiple identities with the same name

- Identity id is used between ServerGroup dialog and Identity dialog
- Save order is using to store the Identity of a ServerGroup


This addresses bug 311300.
    https://bugs.kde.org/show_bug.cgi?id=311300


Diffs (updated)
-----

  src/irc/servergroupdialog.cpp 75655b3 
  src/application.cpp 71e0f1f 

Diff: http://git.reviewboard.kde.org/r/109588/diff/


Testing
-------


Thanks,

José Millán Soto

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20130319/13494d51/attachment-0001.html>


More information about the Konversation-devel mailing list