<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109588/">http://git.reviewboard.kde.org/r/109588/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looks like a good patch, but it could theoretically cause data loss when run against a legacy config file that uses integers as identity names ... there's two ways to handle that, either by shipping a kconf_update script (see the .upd files in the source tree for examples) that transforms the config file in the same way the code now does, or switching to using a different KConfig key name in saveOptions() and supporting both in readOptions().
kconf_update has proven to be shaky in practice especially without renaming keys (kded runs new .upd scripts immediately on installation time, so if a user upgrades Konvi while it's running and then quits Konvi, the saveOptions() on quits overwrites the changes - it's an annoying design flaw in kconf_update), so since there's no way around a key rename, we might as well just go for the second option ... it makes the app code a little less nice sadly, but it's just more reliable.</pre>
<br />
<p>- Eike</p>
<br />
<p>On March 19th, 2013, 5:53 p.m. UTC, José Millán Soto wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konversation and Eike Hein.</div>
<div>By José Millán Soto.</div>
<p style="color: grey;"><i>Updated March 19, 2013, 5:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Correct handling of multiple identities with the same name
- Identity id is used between ServerGroup dialog and Identity dialog
- Save order is using to store the Identity of a ServerGroup</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=311300">311300</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/application.cpp <span style="color: grey">(71e0f1f)</span></li>
<li>src/irc/servergroupdialog.cpp <span style="color: grey">(75655b3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109588/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>